6d4662d4f7
Hi jamal,
I found some spare time to play around a bit more with you ipt action stuff.
I've tested the patch attached with the testcase here below. It works
fine here. It fixes broken target option checkings (final_check) and a
leak in the merge_options function. I've killed copy_options since I
didn't find any reason why we need it.
--- test.sh ---
tc qdisc del dev wlan0 ingress
tc qdisc add dev wlan0 ingress
tc filter add dev wlan0 parent ffff: protocol ip prio 6 u32 \
match ip src 192.168.0.2/32 flowid 1:16 \
action ipt -j TOS --set-tos Maximize-Reliability
sleep 3
tc -s filter ls dev wlan0 parent ffff:
--- end of test.sh ---
Results:
tablename: mangle hook: NF_IP_PRE_ROUTING
target: TOS set Maximize-Reliability index 0
filter protocol ip pref 6 u32
filter protocol ip pref 6 u32 fh 800: ht divisor 1
filter protocol ip pref 6 u32 fh 800::800 order 2048 key ht 800 bkt 0
flowid 1:16
match c0a80002/ffffffff at 12
action order 1: tablename: mangle hook: NF_IP_PRE_ROUTING
target TOS set Maximize-Reliability
index 18 ref 1 bind 1 installed 3 sec used 0 sec
Action statistics:
Sent 725 bytes 7 pkt (dropped 0, overlimits 0 requeues 0)
rate 0bit 0pps backlog 0b 0p requeues 0
Now, check if options passed to the target are correct.
# tc filter add dev wlan0 parent ffff: protocol ip prio 6 u32 \
match ip dst 192.168.0.2/32 flowid 1:16 \
action ipt -j TOS --set-tos
^^^
missing parameter
ipt: option `--set-tos' requires an argument
tc-ipt v0.1: TOS target: Parameter --set-tos is required
Try `tc-ipt -h' or 'tc-ipt --help' for more information.
btw, how's your schedule ? did you finally get spare time to come to the
netfilter workshop in seville ?
bye,
Pablo
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| README.last | ||
| f_fw.c | ||
| f_route.c | ||
| f_rsvp.c | ||
| f_tcindex.c | ||
| f_u32.c | ||
| m_action.c | ||
| m_estimator.c | ||
| m_gact.c | ||
| m_ipt.c | ||
| m_mirred.c | ||
| m_pedit.c | ||
| m_pedit.h | ||
| m_police.c | ||
| p_icmp.c | ||
| p_ip.c | ||
| p_tcp.c | ||
| p_udp.c | ||
| q_atm.c | ||
| q_cbq.c | ||
| q_dsmark.c | ||
| q_fifo.c | ||
| q_gred.c | ||
| q_hfsc.c | ||
| q_htb.c | ||
| q_ingress.c | ||
| q_netem.c | ||
| q_prio.c | ||
| q_red.c | ||
| q_sfq.c | ||
| q_tbf.c | ||
| tc.c | ||
| tc_cbq.c | ||
| tc_cbq.h | ||
| tc_class.c | ||
| tc_common.h | ||
| tc_core.c | ||
| tc_core.h | ||
| tc_estimator.c | ||
| tc_filter.c | ||
| tc_qdisc.c | ||
| tc_red.c | ||
| tc_red.h | ||
| tc_util.c | ||
| tc_util.h | ||
README.last
Kernel code and interface. -------------------------- * Compile time switches There is only one, but very important, compile time switch. It is not settable by "make config", but should be selected manually and after a bit of thinking in <include/net/pkt_sched.h> PSCHED_CLOCK_SOURCE can take three values: PSCHED_GETTIMEOFDAY PSCHED_JIFFIES PSCHED_CPU PSCHED_GETTIMEOFDAY Default setting is the most conservative PSCHED_GETTIMEOFDAY. It is very slow both because of weird slowness of do_gettimeofday() and because it forces code to use unnatural "timeval" format, where microseconds and seconds fields are separate. Besides that, it will misbehave, when delays exceed 2 seconds (f.e. very slow links or classes bounded to small slice of bandwidth) To resume: as only you will get it working, select correct clock source and forget about PSCHED_GETTIMEOFDAY forever. PSCHED_JIFFIES Clock is derived from jiffies. On architectures with HZ=100 granularity of this clock is not enough to make reasonable bindings to real time. However, taking into account Linux architecture problems, which force us to use artificial integrated clock in any case, this switch is not so bad for schduling even on high speed networks, though policing is not reliable. PSCHED_CPU It is available only for alpha and pentiums with correct CPU timestamp. It is the fastest way, use it when it is available, but remember: not all pentiums have this facility, and a lot of them have clock, broken by APM etc. etc.