iproute2/bridge
Benjamin Poirier b262a9becb bridge: Fix output with empty vlan lists
Consider this configuration:

ip link add br0 type bridge
ip link add vx0 type vxlan dstport 4789 external
ip link set dev vx0 master br0
bridge vlan del vid 1 dev vx0
ip link add vx1 type vxlan dstport 4790 external
ip link set dev vx1 master br0

	root@vsid:/src/iproute2# ./bridge/bridge vlan
	port    vlan-id
	br0      1 PVID Egress Untagged

	vx0     None
	vx1      1 PVID Egress Untagged

	root@vsid:/src/iproute2#

Note the useless and inconsistent empty lines.

	root@vsid:/src/iproute2# ./bridge/bridge vlan tunnelshow
	port    vlan-id tunnel-id
	br0
	vx0     None
	vx1

What's the difference between "None" and ""?

	root@vsid:/src/iproute2# ./bridge/bridge -j -p vlan tunnelshow
	[ {
		"ifname": "br0",
		"tunnels": [ ]
	    },{
		"ifname": "vx1",
		"tunnels": [ ]
	    } ]

Why does vx0 appear in normal output and not json output?
Why output an empty list for br0 and vx1?

Fix these inconsistencies and avoid outputting entries with no values. This
makes the behavior consistent with other iproute2 commands, for example
`ip -6 addr`: if an interface doesn't have any ipv6 addresses, it is not
part of the listing.

Fixes: 8652eeb3ab ("bridge: vlan: support for per vlan tunnel info")
Signed-off-by: Benjamin Poirier <bpoirier@cumulusnetworks.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
2020-05-04 17:13:53 -07:00
..
.gitignore Add bridge command 2012-08-01 15:23:49 -07:00
Makefile SPDX license identifiers 2017-11-24 12:21:35 -08:00
br_common.h bridge: mdb: restore valid json output 2019-04-17 16:27:06 -07:00
bridge.c ip bridge: Set NETLINK_GET_STRICT_CHK on socket 2018-12-27 15:36:29 -08:00
fdb.c bridge: fdb get support 2019-10-01 08:22:32 -07:00
link.c State of bridge STP port are now case insensitive 2020-04-20 09:45:37 -07:00
mdb.c Merge branch 'master' into next 2019-06-10 10:32:07 -07:00
monitor.c bridge: mdb: restore valid json output 2019-04-17 16:27:06 -07:00
vlan.c bridge: Fix output with empty vlan lists 2020-05-04 17:13:53 -07:00