iproute2/lib
Martynas Pumputis 83d4d61bc9 libbpf: fix attach of prog with multiple sections
When BPF programs which consists of multiple executable sections via
iproute2+libbpf (configured with LIBBPF_FORCE=on), we noticed that a
wrong section can be attached to a device. E.g.:

    # tc qdisc replace dev lxc_health clsact
    # tc filter replace dev lxc_health ingress prio 1 \
        handle 1 bpf da obj bpf_lxc.o sec from-container
    # tc filter show dev lxc_health ingress filter protocol all
        pref 1 bpf chain 0 filter protocol all pref 1 bpf chain 0
        handle 0x1 bpf_lxc.o:[__send_drop_notify] <-- WRONG SECTION
        direct-action not_in_hw id 38 tag 7d891814eda6809e jited

After taking a closer look into load_bpf_object() in lib/bpf_libbpf.c,
we noticed that the filter used in the program iterator does not check
whether a program section name matches a requested section name
(cfg->section). This can lead to a wrong prog FD being used to attach
the program.

Fixes: 6d61a2b557 ("lib: add libbpf support")
Signed-off-by: Martynas Pumputis <m@lambda.lt>
Acked-by: Hangbin Liu <haliu@redhat.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
2021-07-06 16:59:39 -07:00
..
Makefile build: Fix link errors on some systems 2021-01-18 12:28:47 -08:00
bpf_glue.c lib/bpf: add missing limits.h includes 2021-03-16 22:53:53 -07:00
bpf_legacy.c lib: bpf_legacy: avoid to pass invalid argument to close() 2021-05-06 14:43:54 +00:00
bpf_libbpf.c libbpf: fix attach of prog with multiple sections 2021-07-06 16:59:39 -07:00
cg_map.c lib: ignore invalid mounts in cg_init_map 2020-10-11 23:02:35 -07:00
color.c lib/color: make local functions static 2018-11-19 11:42:44 -08:00
coverity_model.c scrub out whitespace issues 2016-03-27 10:50:14 -07:00
exec.c netns: switch netns in the child when executing commands 2019-06-20 14:30:41 -07:00
fs.c Merge branch 'main' into next 2021-07-01 14:29:42 +00:00
inet_proto.c ip: add a new parameter -Numeric 2019-06-18 08:37:47 -07:00
json_print.c json_print: Add print_tv() 2021-03-19 15:00:08 +00:00
json_print_math.c build: Fix link errors on some systems 2021-01-18 12:28:47 -08:00
json_writer.c json: fix backslash escape typo in jsonw_puts 2019-07-19 10:48:38 -07:00
libgenl.c libgenl: make genl_add_mcast_grp set errno on error 2021-05-17 11:59:37 -07:00
libnetlink.c libnetlink: add bridge vlan dump request helper 2021-04-22 05:13:29 +00:00
ll_addr.c lib/ll_addr: whitespace and indent cleanup 2018-11-19 11:42:44 -08:00
ll_map.c ip: allow to use alternative names as handle 2019-10-28 07:35:29 -07:00
ll_proto.c m_mpls: add mac_push action 2020-10-20 08:57:08 -06:00
ll_types.c ip: add a new parameter -Numeric 2019-06-18 08:37:47 -07:00
mnl_utils.c utils: Introduce helper routines for generic socket recv 2021-03-03 04:00:04 +00:00
mpls_ntop.c SPDX license identifiers 2017-11-24 12:21:35 -08:00
mpls_pton.c SPDX license identifiers 2017-11-24 12:21:35 -08:00
names.c tc: drop unused name_to_id function 2018-11-19 11:42:44 -08:00
namespace.c lib/namespace: fix ip -all netns return code 2021-02-22 18:17:56 -08:00
rt_names.c lib: rt_names: Add rtnl_dsfield_get_name() 2021-01-18 04:09:29 +00:00
utils.c utils: bump max args number to 512 for batch files 2021-06-18 02:57:05 +00:00
utils_math.c build: Fix link errors on some systems 2021-01-18 12:28:47 -08:00