iproute2/tc
Patrick McHardy 720a2e8d99 TC action parsing bug fix
>
> Is it a bug that:
>
>   # tc filter add dev eth0 parent 1: protocol ip prio 0 handle 0xfffffff
>     fw police rate 1 burst 1 mpu 0 mtu 1 action drop
>                                          ^^^^^^^^^^^
> creates a filter that looks like:
>
>   # tc filter ls dev eth0
>   filter parent 1: protocol ip pref 49152 fw
>   filter parent 1: protocol ip pref 49152 fw handle 0xfffffff police 0x1
>   rate 0bit burst 0b mtu 1b action reclassify
>                             ^^^^^^^^^^^^^^^^^
>   ref -543190236 bind 4
>
> (which reclassifies and thus lets 0xfffffff-marked packets through).
>
> I'm pretty sure this used to work under 2.4.x (though I no longer have a
> 2.4 box to test with), but it hasn't worked on any of the 2.6.x kernels
> I've tried (with both iproute2-ss060323 and 070710).

Good catch. It seems this is merely a parsing error, iproute doesn't
have an "action" parameter and aborts parsing, so it uses the default
value of "RECLASSIFY". It never had this parameter, so this patch
removes it from the help text and makes it return an error.
2007-08-22 10:00:41 -07:00
..
.gitignore Add ignore files to make using git easier 2006-08-08 12:04:38 -07:00
Makefile Snapshot update for 2.6.22 2007-06-25 09:42:30 -07:00
README.last (Logical change 1.3) 2004-04-15 20:56:59 +00:00
em_cmp.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
em_meta.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
em_nbyte.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
em_u32.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
emp_ematch.l Remove trailing whitespace 2006-12-05 10:10:22 -08:00
emp_ematch.y Thomas's ematch fixes for lex. 2005-07-08 22:08:47 +00:00
f_basic.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
f_fw.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
f_route.c Fix batch mode handle usage. 2005-03-14 22:19:16 +00:00
f_rsvp.c Use parse_rtattr_nested 2005-01-18 22:11:58 +00:00
f_tcindex.c Use parse_rtattr_nested 2005-01-18 22:11:58 +00:00
f_u32.c Eliminate trailing whitespace 2006-12-13 17:05:50 -08:00
m_action.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
m_ematch.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
m_ematch.h Remove trailing whitespace 2006-12-05 10:10:22 -08:00
m_estimator.c Replace "usec" by "time" in function names 2007-03-13 14:42:17 -07:00
m_gact.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
m_ipt.c [Fwd: Re: more iproute2 issues (not critical)] 2007-06-20 10:52:22 -07:00
m_mirred.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
m_pedit.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
m_pedit.h Remove trailing whitespace 2006-12-05 10:10:22 -08:00
m_police.c TC action parsing bug fix 2007-08-22 10:00:41 -07:00
p_icmp.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
p_ip.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
p_tcp.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
p_udp.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
q_atm.c Use parse_rtattr_nested 2005-01-18 22:11:58 +00:00
q_cbq.c Add sprint_ticks() function and use in CBQ 2007-03-13 14:42:18 -07:00
q_dsmark.c Use NLMSG_TAIL 2005-01-18 01:24:18 +00:00
q_fifo.c : prevent tc crashes 2004-09-28 18:35:49 +00:00
q_gred.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
q_hfsc.c Replace "usec" by "time" in function names 2007-03-13 14:42:17 -07:00
q_htb.c Introduce tc_calc_xmitsize and use where appropriate 2007-03-13 14:42:15 -07:00
q_ingress.c : prevent tc crashes 2004-09-28 18:35:49 +00:00
q_netem.c Add TC_LIB_DIR environment variable. 2007-06-20 15:31:40 -07:00
q_prio.c : prevent tc crashes 2004-09-28 18:35:49 +00:00
q_red.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
q_sfq.c : prevent tc crashes 2004-09-28 18:35:49 +00:00
q_tbf.c Replace "usec" by "time" in function names 2007-03-13 14:42:17 -07:00
tc.c Add TC_LIB_DIR environment variable. 2007-06-20 15:31:40 -07:00
tc_cbq.c Replace "usec" by "time" in function names 2007-03-13 14:42:17 -07:00
tc_cbq.h (Logical change 1.3) 2004-04-15 20:56:59 +00:00
tc_class.c Fixes for tc help commands 2006-12-14 15:01:30 -08:00
tc_common.h This patch adds ability to monitor tc events similar to ipmonitor. 2006-08-08 11:55:15 -07:00
tc_core.c Handle different kernel clock resolutions 2007-03-13 14:42:19 -07:00
tc_core.h Revert "Increase internal clock resolution to nsec" 2007-03-14 10:14:07 -07:00
tc_estimator.c Introduce TIME_UNITS_PER_SEC to represent internal clock resolution 2007-03-13 14:42:16 -07:00
tc_filter.c iproute2: Support IFF_LOWER_UP and IFF_DORMANT 2007-06-19 16:40:40 -07:00
tc_monitor.c update rest to use nl_mgrp 2007-03-13 14:39:05 -07:00
tc_qdisc.c Fixes for tc help commands 2006-12-14 15:01:30 -08:00
tc_red.c Use tc_calc_xmittime() where appropriate 2007-03-13 14:42:14 -07:00
tc_red.h (Logical change 1.3) 2004-04-15 20:56:59 +00:00
tc_util.c Add TC_LIB_DIR environment variable. 2007-06-20 15:31:40 -07:00
tc_util.h Add TC_LIB_DIR environment variable. 2007-06-20 15:31:40 -07:00

README.last

Kernel code and interface.
--------------------------

* Compile time switches

There is only one, but very important, compile time switch.
It is not settable by "make config", but should be selected
manually and after a bit of thinking in <include/net/pkt_sched.h>

PSCHED_CLOCK_SOURCE can take three values:

	PSCHED_GETTIMEOFDAY
	PSCHED_JIFFIES
	PSCHED_CPU


 PSCHED_GETTIMEOFDAY

Default setting is the most conservative PSCHED_GETTIMEOFDAY.
It is very slow both because of weird slowness of do_gettimeofday()
and because it forces code to use unnatural "timeval" format,
where microseconds and seconds fields are separate.
Besides that, it will misbehave, when delays exceed 2 seconds
(f.e. very slow links or classes bounded to small slice of bandwidth)
To resume: as only you will get it working, select correct clock
source and forget about PSCHED_GETTIMEOFDAY forever.


 PSCHED_JIFFIES

Clock is derived from jiffies. On architectures with HZ=100
granularity of this clock is not enough to make reasonable
bindings to real time. However, taking into account Linux
architecture problems, which force us to use artificial
integrated clock in any case, this switch is not so bad
for schduling even on high speed networks, though policing
is not reliable.


 PSCHED_CPU

It is available only for alpha and pentiums with correct
CPU timestamp. It is the fastest way, use it when it is available,
but remember: not all pentiums have this facility, and
a lot of them have clock, broken by APM etc. etc.