> > Is it a bug that: > > # tc filter add dev eth0 parent 1: protocol ip prio 0 handle 0xfffffff > fw police rate 1 burst 1 mpu 0 mtu 1 action drop > ^^^^^^^^^^^ > creates a filter that looks like: > > # tc filter ls dev eth0 > filter parent 1: protocol ip pref 49152 fw > filter parent 1: protocol ip pref 49152 fw handle 0xfffffff police 0x1 > rate 0bit burst 0b mtu 1b action reclassify > ^^^^^^^^^^^^^^^^^ > ref -543190236 bind 4 > > (which reclassifies and thus lets 0xfffffff-marked packets through). > > I'm pretty sure this used to work under 2.4.x (though I no longer have a > 2.4 box to test with), but it hasn't worked on any of the 2.6.x kernels > I've tried (with both iproute2-ss060323 and 070710). Good catch. It seems this is merely a parsing error, iproute doesn't have an "action" parameter and aborts parsing, so it uses the default value of "RECLASSIFY". It never had this parameter, so this patch removes it from the help text and makes it return an error. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile | ||
| README.last | ||
| em_cmp.c | ||
| em_meta.c | ||
| em_nbyte.c | ||
| em_u32.c | ||
| emp_ematch.l | ||
| emp_ematch.y | ||
| f_basic.c | ||
| f_fw.c | ||
| f_route.c | ||
| f_rsvp.c | ||
| f_tcindex.c | ||
| f_u32.c | ||
| m_action.c | ||
| m_ematch.c | ||
| m_ematch.h | ||
| m_estimator.c | ||
| m_gact.c | ||
| m_ipt.c | ||
| m_mirred.c | ||
| m_pedit.c | ||
| m_pedit.h | ||
| m_police.c | ||
| p_icmp.c | ||
| p_ip.c | ||
| p_tcp.c | ||
| p_udp.c | ||
| q_atm.c | ||
| q_cbq.c | ||
| q_dsmark.c | ||
| q_fifo.c | ||
| q_gred.c | ||
| q_hfsc.c | ||
| q_htb.c | ||
| q_ingress.c | ||
| q_netem.c | ||
| q_prio.c | ||
| q_red.c | ||
| q_sfq.c | ||
| q_tbf.c | ||
| tc.c | ||
| tc_cbq.c | ||
| tc_cbq.h | ||
| tc_class.c | ||
| tc_common.h | ||
| tc_core.c | ||
| tc_core.h | ||
| tc_estimator.c | ||
| tc_filter.c | ||
| tc_monitor.c | ||
| tc_qdisc.c | ||
| tc_red.c | ||
| tc_red.h | ||
| tc_util.c | ||
| tc_util.h | ||
README.last
Kernel code and interface. -------------------------- * Compile time switches There is only one, but very important, compile time switch. It is not settable by "make config", but should be selected manually and after a bit of thinking in <include/net/pkt_sched.h> PSCHED_CLOCK_SOURCE can take three values: PSCHED_GETTIMEOFDAY PSCHED_JIFFIES PSCHED_CPU PSCHED_GETTIMEOFDAY Default setting is the most conservative PSCHED_GETTIMEOFDAY. It is very slow both because of weird slowness of do_gettimeofday() and because it forces code to use unnatural "timeval" format, where microseconds and seconds fields are separate. Besides that, it will misbehave, when delays exceed 2 seconds (f.e. very slow links or classes bounded to small slice of bandwidth) To resume: as only you will get it working, select correct clock source and forget about PSCHED_GETTIMEOFDAY forever. PSCHED_JIFFIES Clock is derived from jiffies. On architectures with HZ=100 granularity of this clock is not enough to make reasonable bindings to real time. However, taking into account Linux architecture problems, which force us to use artificial integrated clock in any case, this switch is not so bad for schduling even on high speed networks, though policing is not reliable. PSCHED_CPU It is available only for alpha and pentiums with correct CPU timestamp. It is the fastest way, use it when it is available, but remember: not all pentiums have this facility, and a lot of them have clock, broken by APM etc. etc.