matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
iproute2/ip
History
Roopa Prabhu e278010416 mpls: always set type RTN_UNICAST and scope RT_SCOPE_UNIVERSE for 
This patch fixes incorrect -EINVAL errors due to invalid
scope and type during mpls route deletes.

$ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route show
100 as to 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route del 100 as 200 via inet 10.1.1.2 dev swp1
RTNETLINK answers: Invalid argument

$ip -f mpls route del 100
RTNETLINK answers: Invalid argument

After patch:

$ip -f mpls route show
100 as to 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route del 100 as 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route show

Always set type to RTN_UNICAST for mpls route add/deletes.
Also to keep things consistent with kernel set scope to
RT_SCOPE_UNIVERSE for both mpls and ipv6 routes. Both mpls and ipv6 route
deletes ignore scope.

Suggested-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Vivek Venkataraman <vivek@cumulusnetworks.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
(cherry picked from commit f638e9f7c8)
 		2015-07-06 14:55:34 -07:00
..
.gitignore Another .gitignore file. 2006-08-08 12:11:23 -07:00
Makefile Revert "ip netns: Fix rtnl error while print netns list" 2015-04-13 08:50:10 -07:00
ifcfg Remove trailing whitespace 2006-12-05 10:10:22 -08:00
ip.c ip: Add color output option 2015-05-04 08:39:17 -07:00
ip6tunnel.c iproute2: ip6_tunnel mode bugfixes: any,vti6 2014-11-02 11:48:43 -08:00
ip_common.h netns: allow to dump and monitor nsid 2015-04-20 10:02:38 -07:00
ipaddress.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
ipaddrlabel.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
ipfou.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
ipl2tp.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
iplink.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
iplink_bond.c add a source addres length parameter to rt_addr_n2a 2015-03-24 15:45:23 -07:00
iplink_bond_slave.c iproute2: allow to change slave options via type_slave 2014-09-28 16:05:24 -07:00
iplink_bridge.c add bridge master device support 2014-09-28 16:33:29 -07:00
iplink_bridge_slave.c add bridge_slave device support 2014-09-28 16:31:04 -07:00
iplink_can.c can: Add support for CAN FD non-ISO feature 2015-02-05 10:35:24 -08:00
iplink_hsr.c ip link: Shortify printing the usage of link type 2014-10-09 08:29:47 -07:00
iplink_ipoib.c ip link: Shortify printing the usage of link type 2014-10-09 08:29:47 -07:00
iplink_ipvlan.c ip link: Add ipvlan support to the iproute2/ip util 2014-12-03 09:37:37 -08:00
iplink_macvlan.c ip link: Shortify printing the usage of link type 2014-10-09 08:29:47 -07:00
iplink_macvtap.c ip link: Shortify printing the usage of link type 2014-10-09 08:29:47 -07:00
iplink_vlan.c ip link: Shortify printing the usage of link type 2014-10-09 08:29:47 -07:00
iplink_vxlan.c vxlan: Group policy extension 2015-02-05 10:31:43 -08:00
ipmaddr.c ipmaddr: add whitespace around = 2013-03-14 13:44:25 -07:00
ipmonitor.c netns: allow to dump and monitor nsid 2015-04-20 10:02:38 -07:00
ipmroute.c mroute: "ip mroute show" not working when "to" and/or "from" is given 2015-06-25 08:47:07 -04:00
ipneigh.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
ipnetconf.c ip monitor: Allow to filter events by dev 2014-11-29 11:15:40 -08:00
ipnetns.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
ipntable.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
ipprefix.c add a source addres length parameter to rt_addr_n2a 2015-03-24 15:45:23 -07:00
iproute.c mpls: always set type RTN_UNICAST and scope RT_SCOPE_UNIVERSE for 2015-07-06 14:55:34 -07:00
iprule.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
iptoken.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
iptunnel.c Fix changing tunnel remote and local address to any 2015-06-25 08:45:24 -04:00
iptuntap.c ip tuntap: Added missing commands in usage 2014-09-28 16:19:31 -07:00
ipxfrm.c ip-xfrm: support 'proto any' with 'sport' and 'dport' 2015-04-20 09:56:44 -07:00
link_gre.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
link_gre6.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
link_ip6tnl.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
link_iptnl.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
link_veth.c ip link: Shortify printing the usage of link type 2014-10-09 08:29:47 -07:00
link_vti.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
link_vti6.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
routef ip/routef lifesaver 2007-07-10 18:29:20 -07:00
routel (Logical change 1.3) 2004-04-15 20:56:59 +00:00
rtm_map.c (Logical change 1.3) 2004-04-15 20:56:59 +00:00
rtmon.c Add define for nlmsg_types with timestamp 2015-01-13 17:34:47 -08:00
rtpr (Logical change 1.3) 2004-04-15 20:56:59 +00:00
static-syms.c Fix build when shared libraries are disabled 2013-03-13 08:29:59 -07:00
tcp_metrics.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
tunnel.c tunnel: decode ESP tunnel type 2014-12-03 19:08:41 -08:00
tunnel.h Fix FSF address in file headers 2013-12-06 15:05:07 -08:00
xfrm.h Fix FSF address in file headers 2013-12-06 15:05:07 -08:00
xfrm_monitor.c xfrm: fix build with later kernel headers 2015-04-10 13:17:54 -07:00
xfrm_policy.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00
xfrm_state.c libnetlink: add size argument to rtnl_talk 2015-05-27 13:00:21 -07:00