matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix array out of bounds problem 

The current kernel generates 71 possible header fields, but
MAX_FIELDS in lnstat is only 64. This leads to referencing outside
of the array. To fix, increase size of array and chop off parsing
at MAX_FIELDS - 1.
This commit is contained in:
Stephen Hemminger 2008-06-30 10:37:28 -07:00
parent 4ffc44ca7c
commit f493dc3009
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
misc/lnstat.c
View File

@ -17,7 +17,7 @@
*/ */
/* Maximum number of fields that can be displayed */ /* Maximum number of fields that can be displayed */
#define MAX_FIELDS 64 #define MAX_FIELDS 128
/* Maximum number of header lines */ /* Maximum number of header lines */
#define HDR_LINES 10 #define HDR_LINES 10
@ -121,9 +121,12 @@ static int map_field_params(struct lnstat_file *lnstat_files,
if (!fps->params[j].print.width) if (!fps->params[j].print.width)
fps->params[j].print.width = fps->params[j].print.width =
FIELD_WIDTH_DEFAULT; FIELD_WIDTH_DEFAULT;
j++;
if (++j >= MAX_FIELDS - 1)
goto full;
} }
} }
full:
fps->num = j; fps->num = j;
return 1; return 1;
} }