From ee09370a7206ad361653e437ca6429533a1c02a9 Mon Sep 17 00:00:00 2001 From: Baruch Siach Date: Thu, 27 Jun 2019 21:37:18 +0300 Subject: [PATCH] devlink: fix format string warning for 32bit targets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 32bit targets define uint64_t as long long unsigned. This leads to the following build warning: devlink.c: In function ‘pr_out_u64’: devlink.c:1729:11: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t {aka long long unsigned int}’ [-Wformat=] pr_out("%s %lu", name, val); ^ devlink.c:59:21: note: in definition of macro ‘pr_out’ fprintf(stdout, ##args); \ ^~~~ Use uint64_t specific conversion specifiers in the format string to fix that. Cc: Aya Levin Cc: Moshe Shemesh Signed-off-by: Baruch Siach Signed-off-by: Stephen Hemminger --- devlink/devlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 4e277f7b..97b93730 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -1748,9 +1748,9 @@ static void pr_out_u64(struct dl *dl, const char *name, uint64_t val) jsonw_u64_field(dl->jw, name, val); } else { if (g_indent_newline) - pr_out("%s %lu", name, val); + pr_out("%s %"PRIu64, name, val); else - pr_out(" %s %lu", name, val); + pr_out(" %s %"PRIu64, name, val); } } @@ -1775,7 +1775,7 @@ static void pr_out_uint64_value(struct dl *dl, uint64_t value) if (dl->json_output) jsonw_u64(dl->jw, value); else - pr_out(" %lu", value); + pr_out(" %"PRIu64, value); } static void pr_out_binary_value(struct dl *dl, uint8_t *data, uint32_t len)