matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tc simple action: bug fix 

Failed compile
m_simple.c: In function ‘parse_simple’:
m_simple.c:154:6: warning: too many arguments for format [-Wformat-extra-args]
      *argv);
      ^
m_simple.c:103:14: warning: unused variable ‘maybe_bind’ [-Wunused-variable]

Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
This commit is contained in:
Jamal Hadi Salim 2016-05-24 07:52:48 -04:00 committed by Stephen Hemminger
parent f8daee42a5
commit e70b9f16ea
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tc/m_simple.c
View File

@ -100,7 +100,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
struct tc_defact sel = {};
int argc = *argc_p;
char **argv = *argv_p;
int ok = 0, maybe_bind = 0;
int ok = 0;
struct rtattr *tail;
char *simpdata = NULL;
@ -150,7 +150,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
if (matches(*argv, "index") == 0) {
NEXT_ARG();
if (get_u32(&sel.index, *argv, 10)) {
fprintf(stderr, "simple: Illegal \"index\"\n",
fprintf(stderr, "simple: Illegal \"index\" (%s)\n",
*argv);
return -1;
}
@ -171,7 +171,6 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
return -1;
}
sel.action = TC_ACT_PIPE;
tail = NLMSG_TAIL(n);