From d9b868436a6fce8986560178c6d1a78072e21861 Mon Sep 17 00:00:00 2001 From: Andrea Claudi Date: Tue, 10 Mar 2020 13:15:17 +0100 Subject: [PATCH] nexthop: fix error reporting in filter dump nh_dump_filter is missing a return value check in two cases. Fix this simply adding an assignment to the proper variable. Fixes: 63df8e8543b03 ("Add support for nexthop objects") Signed-off-by: Andrea Claudi Reviewed-by: David Ahern Signed-off-by: Stephen Hemminger --- ip/ipnexthop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ip/ipnexthop.c b/ip/ipnexthop.c index 9f860c8c..99f89630 100644 --- a/ip/ipnexthop.c +++ b/ip/ipnexthop.c @@ -59,13 +59,13 @@ static int nh_dump_filter(struct nlmsghdr *nlh, int reqlen) } if (filter.groups) { - addattr_l(nlh, reqlen, NHA_GROUPS, NULL, 0); + err = addattr_l(nlh, reqlen, NHA_GROUPS, NULL, 0); if (err) return err; } if (filter.master) { - addattr32(nlh, reqlen, NHA_MASTER, filter.master); + err = addattr32(nlh, reqlen, NHA_MASTER, filter.master); if (err) return err; }