From bffb68b6c28a942d5341a912f5a11894f8bcf243 Mon Sep 17 00:00:00 2001 From: Hangbin Liu Date: Thu, 8 Sep 2016 10:26:57 +0800 Subject: [PATCH] ip route: check ftell, fseek return value ftell() may return -1 in error case, which is not handled and therefore pass a negative offset to fseek(). The return code of fseek() is also not checked. Reported-by: Phil Sutter Signed-off-by: Hangbin Liu --- ip/iproute.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index 0bc01368..98bfad6c 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -1862,6 +1862,11 @@ static int iproute_restore(void) exit(-1); pos = ftell(stdin); + if (pos == -1) { + perror("Failed to restore: ftell"); + exit(-1); + } + for (prio = 0; prio < 3; prio++) { int err; @@ -1869,7 +1874,10 @@ static int iproute_restore(void) if (err) exit(err); - fseek(stdin, pos, SEEK_SET); + if (fseek(stdin, pos, SEEK_SET) == -1) { + perror("Failed to restore: fseek"); + exit(-1); + } } exit(0);