matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tc_class: fix snprintf warning 

Size buffer big enough to avoid any possible overflow.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Stephen Hemminger 2018-03-19 16:21:51 -07:00
parent fcb18aa3d9
commit b8a6088e13
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tc/tc_class.c
View File

@ -219,7 +219,7 @@ static void graph_cls_show(FILE *fp, char *buf, struct hlist_head *root_list,
char cls_id_str[256] = {}; char cls_id_str[256] = {};
struct rtattr *tb[TCA_MAX + 1]; struct rtattr *tb[TCA_MAX + 1];
struct qdisc_util *q; struct qdisc_util *q;
char str[100] = {}; char str[300] = {};
hlist_for_each_safe(n, tmp_cls, root_list) { hlist_for_each_safe(n, tmp_cls, root_list) {
struct hlist_node *c, *tmp_chld; struct hlist_node *c, *tmp_chld;
@ -242,7 +242,8 @@ static void graph_cls_show(FILE *fp, char *buf, struct hlist_head *root_list,
graph_indent(buf, cls, 0, 0); graph_indent(buf, cls, 0, 0);
print_tc_classid(cls_id_str, sizeof(cls_id_str), cls->id); print_tc_classid(cls_id_str, sizeof(cls_id_str), cls->id);
sprintf(str, "+---(%s)", cls_id_str); snprintf(str, sizeof(str),
"+---(%s)", cls_id_str);
strcat(buf, str); strcat(buf, str);
parse_rtattr(tb, TCA_MAX, (struct rtattr *)cls->data, parse_rtattr(tb, TCA_MAX, (struct rtattr *)cls->data,