matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

devlink: Fix help message for dpipe 

Have one help message for all dpipe commands, as it is done for the rest
of the devlink object. Possible and required options to the help.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Jiri Pirko 2020-04-04 18:16:19 +02:00 committed by Stephen Hemminger
parent 342f462efa
commit b2522187d8
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
devlink/devlink.c
View File

@ -4976,15 +4976,19 @@ static int cmd_dpipe_headers_show(struct dl *dl)
return err;
}
static void cmd_dpipe_header_help(void)
static void cmd_dpipe_help(void)
{
pr_err("Usage: devlink dpipe headers show DEV\n");
pr_err("Usage: devlink dpipe table show DEV [ name TABLE_NAME ]\n");
pr_err(" devlink dpipe table set DEV name TABLE_NAME\n");
pr_err(" [ counters_enabled { true | false } ]\n");
pr_err(" devlink dpipe table dump DEV name TABLE_NAME\n");
pr_err(" devlink dpipe header show DEV\n");
}
static int cmd_dpipe_header(struct dl *dl)
{
if (dl_argv_match(dl, "help") || dl_no_arg(dl)) {
cmd_dpipe_header_help();
cmd_dpipe_help();
return 0;
} else if (dl_argv_match(dl, "show")) {
dl_arg_inc(dl);
@ -5800,16 +5804,10 @@ out:
return err;
}
static void cmd_dpipe_table_help(void)
{
pr_err("Usage: devlink dpipe table [ OBJECT-LIST ]\n"
"where OBJECT-LIST := { show | set | dump }\n");
}
static int cmd_dpipe_table(struct dl *dl)
{
if (dl_argv_match(dl, "help") || dl_no_arg(dl)) {
cmd_dpipe_table_help();
cmd_dpipe_help();
return 0;
} else if (dl_argv_match(dl, "show")) {
dl_arg_inc(dl);
@ -5825,12 +5823,6 @@ static int cmd_dpipe_table(struct dl *dl)
return -ENOENT;
}
static void cmd_dpipe_help(void)
{
pr_err("Usage: devlink dpipe [ OBJECT-LIST ]\n"
"where OBJECT-LIST := { header | table }\n");
}
static int cmd_dpipe(struct dl *dl)
{
if (dl_argv_match(dl, "help") || dl_no_arg(dl)) {