From a77905ef6aeaf85b26c51a62e409a7ccc5128410 Mon Sep 17 00:00:00 2001 From: David Ward Date: Mon, 18 May 2015 11:35:10 -0400 Subject: [PATCH] tc: gred: Print usage text if no arguments appear after "gred" This is more helpful to the user, since the command takes two forms, and the message that would otherwise appear about missing parameters assumes one of those forms. Signed-off-by: David Ward --- tc/q_gred.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tc/q_gred.c b/tc/q_gred.c index a3dc722b..65caeee6 100644 --- a/tc/q_gred.c +++ b/tc/q_gred.c @@ -213,6 +213,10 @@ static int gred_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct n argc--; argv++; } + if (!ok) { + explain(); + return -1; + } if (!opt.qth_min || !opt.qth_max || !opt.limit || !avpkt || (opt.DP<0)) { fprintf(stderr, "Required parameter (min, max, limit, "