matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tc: q_ets: drop dead code from argument parsing 

Checking for nbands to be at least 1 at this point is useless. Indeed:
- ets requires "bands", "quanta" or "strict" to be specified
- if "bands" is specified, nbands cannot be negative, see parse_nbands()
- if "strict" is specified, nstrict cannot be negative, see
  parse_nbands()
- if "quantum" is specified, nquanta cannot be negative, see
  parse_quantum()
- if "bands" is not specified, nbands is set to nstrict+nquanta
- the previous if statement takes care of the case when none of them are
  specified and nbands is 0, terminating execution.

Thus nbands cannot be < 1 at this point and this code cannot be executed.

Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
This commit is contained in:
Andrea Claudi 2021-05-01 18:44:35 +02:00 committed by David Ahern
parent 570d2cf0ec
commit a2f1f66075
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tc/q_ets.c
View File

@ -147,11 +147,6 @@ parse_priomap:
explain(); explain();
return -1; return -1;
} }
if (nbands < 1) {
fprintf(stderr, "The number of \"bands\" must be >= 1\n");
explain();
return -1;
}
if (nstrict + nquanta > nbands) { if (nstrict + nquanta > nbands) {
fprintf(stderr, "Not enough total bands to cover all the strict bands and quanta\n"); fprintf(stderr, "Not enough total bands to cover all the strict bands and quanta\n");
explain(); explain();