From 99500b56d94dfa735a3d088fdbdde6c0c2638e78 Mon Sep 17 00:00:00 2001 From: Fan Du Date: Mon, 30 Sep 2013 21:09:05 -0700 Subject: [PATCH] xfrm: use memcpy to suppress gcc phony buffer overflow warning. This bug is reported from below link: https://bugzilla.redhat.com/show_bug.cgi?id=982761 An simplified command from its original reproducing method in bugzilla: ip xfrm state add src 10.0.0.2 dst 10.0.0.1 proto ah spi 0x12345678 auth md5 12 will cause below spew from gcc. Reported-by: Sohny Thomas --- ip/xfrm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/xfrm_state.c b/ip/xfrm_state.c index 389942c0..f4ad4cb1 100644 --- a/ip/xfrm_state.c +++ b/ip/xfrm_state.c @@ -162,7 +162,7 @@ static int xfrm_algo_parse(struct xfrm_algo *alg, enum xfrm_attr_type_t type, if (len > max) invarg("ALGO-KEYMAT value makes buffer overflow\n", key); - strncpy(buf, key, len); + memcpy(buf, key, len); } }