From 90f0b587d8f77281e88f122855abe42e30c4a4f8 Mon Sep 17 00:00:00 2001 From: Andrea Claudi Date: Thu, 27 Jun 2019 16:47:45 +0200 Subject: [PATCH] tc: netem: fix r parameter in Bernoulli loss model As the man page for tc netem states: To use the Bernoulli model, the only needed parameter is p while the others will be set to the default values r=1-p, 1-h=1 and 1-k=0. However r parameter is erroneusly set to 1, and not to 1-p. Fix this using the same approach of the 4-state loss model. Fixes: 3c7950af598be ("netem: add support for 4 state and GE loss model") Signed-off-by: Andrea Claudi Signed-off-by: Stephen Hemminger --- tc/q_netem.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tc/q_netem.c b/tc/q_netem.c index 6e0e8a8c..d1cd17f8 100644 --- a/tc/q_netem.c +++ b/tc/q_netem.c @@ -284,14 +284,17 @@ static int netem_parse_opt(struct qdisc_util *qu, int argc, char **argv, } } else if (!strcmp(*argv, "gemodel")) { + double p; + NEXT_ARG(); - if (get_percent(&gemodel.p, *argv)) { + if (parse_percent(&p, *argv)) { explain1("loss gemodel p"); return -1; } + set_percent(&gemodel.p, p); /* set defaults */ - set_percent(&gemodel.r, 1.); + set_percent(&gemodel.r, 1. - p); set_percent(&gemodel.h, 0); set_percent(&gemodel.k1, 0); loss_type = NETEM_LOSS_GE;