From 7f1d58d1a1c59d2cc3fdae04e8f03d411fe22905 Mon Sep 17 00:00:00 2001 From: Jianguo Wu Date: Fri, 23 Apr 2021 18:24:50 +0800 Subject: [PATCH] mptcp: make sure flag signal is set when add addr with port When add address with port, it is mean to send an ADD_ADDR to remote, so it must have flag signal set. Fixes: 42fbca91cd61 ("mptcp: add support for port based endpoint") Signed-off-by: Jianguo Wu Acked-by: Matthieu Baerts Signed-off-by: David Ahern --- ip/ipmptcp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c index 5f490f00..44af7234 100644 --- a/ip/ipmptcp.c +++ b/ip/ipmptcp.c @@ -143,6 +143,9 @@ static int mptcp_parse_opt(int argc, char **argv, struct nlmsghdr *n, if (!id_set && !adding) missarg("ID"); + if (port && !(flags & MPTCP_PM_ADDR_FLAG_SIGNAL)) + invarg("flags must have signal when using port", "port"); + attr_addr = addattr_nest(n, MPTCP_BUFLEN, MPTCP_PM_ATTR_ADDR | NLA_F_NESTED); if (id_set)