matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix unterminated readlink() buffer usage 

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
This commit is contained in:
Thomas Jarosch 2011-10-13 10:30:21 +02:00 committed by Stephen Hemminger
parent 707f612c00
commit 788731b320
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
misc/ss.c
View File

@ -273,13 +273,19 @@ static void user_ent_hash_build(void)
unsigned int ino; unsigned int ino;
char lnk[64]; char lnk[64];
int fd; int fd;
ssize_t link_len;
if (sscanf(d1->d_name, "%d%c", &fd, &crap) != 1) if (sscanf(d1->d_name, "%d%c", &fd, &crap) != 1)
continue; continue;
sprintf(name+pos, "%d", fd); sprintf(name+pos, "%d", fd);
if (readlink(name, lnk, sizeof(lnk)-1) < 0 ||
strncmp(lnk, pattern, strlen(pattern))) link_len = readlink(name, lnk, sizeof(lnk)-1);
if (link_len == -1)
continue;
lnk[link_len] = '\0';
if (strncmp(lnk, pattern, strlen(pattern)))
continue; continue;
sscanf(lnk, "socket:[%u]", &ino); sscanf(lnk, "socket:[%u]", &ino);