matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

q_cake: remove useless check on argv 

In cake_parse_opt(), *argv is checked not to be null when parsing for
overhead and mpu parameters. However this is useless, since *argv
matches right before for "overhead" or "mpu".

Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Andrea Claudi 2021-04-14 00:50:20 +02:00 committed by Stephen Hemminger
parent 6b8fa2ea2d
commit 6801ae8273
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tc/q_cake.c
View File

@ -299,8 +299,7 @@ static int cake_parse_opt(struct qdisc_util *qu, int argc, char **argv,
NEXT_ARG(); NEXT_ARG();
overhead = strtol(*argv, &p, 10); overhead = strtol(*argv, &p, 10);
if (!p || *p || !*argv || if (!p || *p || overhead < -64 || overhead > 256) {
overhead < -64 || overhead > 256) {
fprintf(stderr, fprintf(stderr,
"Illegal \"overhead\", valid range is -64 to 256\\n"); "Illegal \"overhead\", valid range is -64 to 256\\n");
return -1; return -1;
@ -312,7 +311,7 @@ static int cake_parse_opt(struct qdisc_util *qu, int argc, char **argv,
NEXT_ARG(); NEXT_ARG();
mpu = strtol(*argv, &p, 10); mpu = strtol(*argv, &p, 10);
if (!p || *p || !*argv || mpu < 0 || mpu > 256) { if (!p || *p || mpu < 0 || mpu > 256) {
fprintf(stderr, fprintf(stderr,
"Illegal \"mpu\", valid range is 0 to 256\\n"); "Illegal \"mpu\", valid range is 0 to 256\\n");
return -1; return -1;