matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tc: Remove pointless assignments in batch() 

All these assignments are later overwritten without reading in between,
so just drop them.

Fixes: 485d0c6001 ("tc: Add batchsize feature for filter and actions")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Phil Sutter 2018-10-18 15:48:48 +02:00 committed by Stephen Hemminger
parent 8d05f33a38
commit 6358bbc381
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tc/tc.c
View File

@ -325,11 +325,11 @@ static int batch(const char *name)
struct batch_buf *head = NULL, *tail = NULL, *buf_pool = NULL; struct batch_buf *head = NULL, *tail = NULL, *buf_pool = NULL;
char *largv[100], *largv_next[100]; char *largv[100], *largv_next[100];
char *line, *line_next = NULL; char *line, *line_next = NULL;
bool bs_enabled_next = false;
bool bs_enabled = false; bool bs_enabled = false;
bool lastline = false; bool lastline = false;
int largc, largc_next; int largc, largc_next;
bool bs_enabled_saved; bool bs_enabled_saved;
bool bs_enabled_next;
int batchsize = 0; int batchsize = 0;
size_t len = 0; size_t len = 0;
int ret = 0; int ret = 0;
@ -358,7 +358,6 @@ static int batch(const char *name)
goto Exit; goto Exit;
largc = makeargs(line, largv, 100); largc = makeargs(line, largv, 100);
bs_enabled = batchsize_enabled(largc, largv); bs_enabled = batchsize_enabled(largc, largv);
bs_enabled_saved = bs_enabled;
do { do {
if (getcmdline(&line_next, &len, stdin) == -1) if (getcmdline(&line_next, &len, stdin) == -1)
lastline = true; lastline = true;
@ -394,7 +393,6 @@ static int batch(const char *name)
len = 0; len = 0;
bs_enabled_saved = bs_enabled; bs_enabled_saved = bs_enabled;
bs_enabled = bs_enabled_next; bs_enabled = bs_enabled_next;
bs_enabled_next = false;
if (largc == 0) { if (largc == 0) {
largc = largc_next; largc = largc_next;