From 6140785236f9dcddde0c61542dcbe9593e7ab650 Mon Sep 17 00:00:00 2001 From: Patrick McHardy Date: Wed, 11 Jul 2007 14:48:12 +0200 Subject: [PATCH] Fix meta ematch usage of 0 values em_meta doesn't send 0 values to the kernel. breaking matching on them and resulting in "Missing value TLV" messages on dump. Signed-off-by: Patrick McHardy --- tc/em_meta.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tc/em_meta.c b/tc/em_meta.c index 5fc0c597..b727422c 100644 --- a/tc/em_meta.c +++ b/tc/em_meta.c @@ -406,11 +406,8 @@ static int meta_parse_eopt(struct nlmsghdr *n, struct tcf_ematch_hdr *hdr, addattr_l(n, MAX_MSG, TCA_EM_META_HDR, &meta_hdr, sizeof(meta_hdr)); - if (lvalue) - dump_value(n, TCA_EM_META_LVALUE, lvalue, &meta_hdr.left); - - if (rvalue) - dump_value(n, TCA_EM_META_RVALUE, rvalue, &meta_hdr.right); + dump_value(n, TCA_EM_META_LVALUE, lvalue, &meta_hdr.left); + dump_value(n, TCA_EM_META_RVALUE, rvalue, &meta_hdr.right); return 0; }