From 611f70b28719f09ca7bb998047915fa2aca52a2d Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel Date: Thu, 23 Jul 2015 09:17:41 +0200 Subject: [PATCH] tc: fix bpf compilation with old glibc Error was: f_bpf.o: In function `bpf_parse_opt': f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv' m_bpf.o: In function `parse_bpf': m_bpf.c:(.text+0x587): undefined reference to `secure_getenv' collect2: error: ld returned 1 exit status There is no special reason to use the secure version of getenv, thus let's simply use getenv(). CC: Daniel Borkmann Fixes: 88eea5395483 ("tc: {f,m}_bpf: allow to retrieve uds path from env") Signed-off-by: Nicolas Dichtel Acked-by: Daniel Borkmann Acked-by: Alexei Starovoitov Tested-by: Yegor Yefremov --- examples/bpf/bpf_agent.c | 2 +- tc/f_bpf.c | 2 +- tc/m_bpf.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/bpf/bpf_agent.c b/examples/bpf/bpf_agent.c index 426b8800..f9b9ce3c 100644 --- a/examples/bpf/bpf_agent.c +++ b/examples/bpf/bpf_agent.c @@ -154,7 +154,7 @@ static void bpf_map_get_from_env(int *tfd) memset(key, 0, sizeof(key)); snprintf(key, sizeof(key), "BPF_MAP%d", i); - val = secure_getenv(key); + val = getenv(key); assert(val != NULL); tfd[i] = atoi(val); diff --git a/tc/f_bpf.c b/tc/f_bpf.c index c21bf33f..490dc6b4 100644 --- a/tc/f_bpf.c +++ b/tc/f_bpf.c @@ -122,7 +122,7 @@ opt_bpf: NEXT_ARG(); if (ebpf) { - bpf_uds_name = secure_getenv(BPF_ENV_UDS); + bpf_uds_name = getenv(BPF_ENV_UDS); bpf_obj = *argv; NEXT_ARG(); diff --git a/tc/m_bpf.c b/tc/m_bpf.c index 9ddb6672..c51f44fc 100644 --- a/tc/m_bpf.c +++ b/tc/m_bpf.c @@ -105,7 +105,7 @@ opt_bpf: NEXT_ARG(); if (ebpf) { - bpf_uds_name = secure_getenv(BPF_ENV_UDS); + bpf_uds_name = getenv(BPF_ENV_UDS); bpf_obj = *argv; NEXT_ARG();