matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

neighbor: check return values 

Need to check for invalid address and buffer overrun in ip neigh
command with invalid paramters.
This commit is contained in:
Stephen Hemminger 2015-01-13 18:06:16 -08:00
parent c3087c10f1
commit 542b0cc759
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ip/ipneigh.c
View File

@ -157,14 +157,19 @@ static int ipneigh_modify(int cmd, int flags, int argc, char **argv)
exit(-1); exit(-1);
} }
req.ndm.ndm_family = dst.family; req.ndm.ndm_family = dst.family;
addattr_l(&req.n, sizeof(req), NDA_DST, &dst.data, dst.bytelen); if (addattr_l(&req.n, sizeof(req), NDA_DST, &dst.data, dst.bytelen) < 0)
return -1;
if (lla && strcmp(lla, "null")) { if (lla && strcmp(lla, "null")) {
char llabuf[20]; char llabuf[20];
int l; int l;
l = ll_addr_a2n(llabuf, sizeof(llabuf), lla); l = ll_addr_a2n(llabuf, sizeof(llabuf), lla);
addattr_l(&req.n, sizeof(req), NDA_LLADDR, llabuf, l); if (l < 0)
return -1;
if (addattr_l(&req.n, sizeof(req), NDA_LLADDR, llabuf, l) < 0)
return -1;
} }
ll_init_map(&rth); ll_init_map(&rth);