From 424adc19bf6365224ab2b594fad78681e0a028c3 Mon Sep 17 00:00:00 2001 From: Li Wei Date: Tue, 10 Jul 2012 16:45:28 +0800 Subject: [PATCH] tc: filter: validate filter priority in userspace. Because we use the high 16 bits of tcm_info to pass prio value to kernel, thus it's range would be [0, 0xffff], without validation in tc when user pass a lager(>65535) priority, the actual priority set in kernel would confuse the user. So, add a validation to ensure prio in the range. --- tc/tc_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/tc_filter.c b/tc/tc_filter.c index 207302fc..04c3b824 100644 --- a/tc/tc_filter.c +++ b/tc/tc_filter.c @@ -105,7 +105,7 @@ int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv) NEXT_ARG(); if (prio) duparg("priority", *argv); - if (get_u32(&prio, *argv, 0)) + if (get_u32(&prio, *argv, 0) || prio > 0xFFFF) invarg(*argv, "invalid priority value"); } else if (matches(*argv, "protocol") == 0) { __u16 id;