From 3ef0c8594283d4891e84b4b8d7d04901416aeae0 Mon Sep 17 00:00:00 2001 From: Patrick McHardy Date: Tue, 7 Oct 2008 17:23:04 +0200 Subject: [PATCH] Refuse "ip link add/replace" without device type parameter Fix confusing error message noticed by Martin Josefsson: Fix typo noticed by Phil Oester: information vs. informatin # ip link add RTNETLINK answers: Operation not supported The reason is missing device type information, refuse this and print a message. Signed-off-by: Patrick McHardy --- ip/iplink.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ip/iplink.c b/ip/iplink.c index 81122aec..1c6b0d47 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -336,6 +336,10 @@ static int iplink_modify(int cmd, unsigned int flags, int argc, char **argv) return -1; } linkinfo->rta_len = (void *)NLMSG_TAIL(&req.n) - (void *)linkinfo; + } else if (flags & NLM_F_CREATE) { + fprintf(stderr, "Not enough information: \"type\" argument " + "is required\n"); + return -1; } if (!(flags & NLM_F_CREATE)) {