matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

libnetlink: __rtnl_talk_iov should only loop max iovlen times 

William reported ip hanging and bisected to a recent commit for batching
allowing more than 1 command to be sent per message. The loop over
recvmsg should never cycle more than iovlen times -- 1 response for
each command in the message.

Fixes: 72a2ff3916 ("lib/libnetlink: Add a new function rtnl_talk_iov")
Signed-off-by: David Ahern <dsahern@gmail.com>
This commit is contained in:
David Ahern 2018-03-01 14:43:08 -08:00 committed by Stephen Hemminger
parent 06867c3719
commit 3dec72672f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/libnetlink.c
View File

@ -670,8 +670,9 @@ next:
free(buf); free(buf);
if (h->nlmsg_seq == seq) if (h->nlmsg_seq == seq)
return 0; return 0;
else else if (i < iovlen)
goto next; goto next;
return 0;
} }
if (rtnl->proto != NETLINK_SOCK_DIAG && if (rtnl->proto != NETLINK_SOCK_DIAG &&