matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ss: Remove useless width specifier in process context print 

Both local address and service, and remote address and service
fields are already printed out in netlink_show_one() before we
start printing process context, by calling sock_addr_print()
twice.

At this point, sock_addr_print() has already forced the remote
service field to be 'serv_width' wide -- that is, 'serv_width'
width has already been consumed, before we print process
context.

Hence, it makes no sense to force the display width of process
context to be 'serv_width' wide again: previous prints have
filled up the line already. Remove the width specifier and
prefix with a space instead, to keep this consistent with fields
which are displayed after the first output line.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio 2017-10-31 18:47:54 +01:00 committed by Stephen Hemminger
parent acbe9118ce
commit 38509fa903
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
misc/ss.c
View File

@ -3594,10 +3594,10 @@ static int netlink_show_one(struct filter *f,
getpidcon(pid, &pid_context); getpidcon(pid, &pid_context);
if (pid_context != NULL) { if (pid_context != NULL) {
printf("proc_ctx=%-*s ", serv_width, pid_context); printf(" proc_ctx=%s", pid_context);
free(pid_context); free(pid_context);
} else { } else {
printf("proc_ctx=%-*s ", serv_width, "unavailable"); printf(" proc_ctx=unavailable");
} }
} }