diff --git a/tc/q_netem.c b/tc/q_netem.c index c83e301e..8abe07f5 100644 --- a/tc/q_netem.c +++ b/tc/q_netem.c @@ -307,7 +307,7 @@ static int netem_parse_opt(struct qdisc_util *qu, int argc, char **argv, /* set defaults */ set_percent(&gemodel.r, 1.); set_percent(&gemodel.h, 0); - set_percent(&gemodel.k1, 1.); + set_percent(&gemodel.k1, 0); loss_type = NETEM_LOSS_GE; if (!NEXT_IS_NUMBER()) @@ -325,6 +325,10 @@ static int netem_parse_opt(struct qdisc_util *qu, int argc, char **argv, explain1("loss gemodel h"); return -1; } + /* netem option is "1-h" but kernel + * expects "h". + */ + gemodel.h = max_percent_value - gemodel.h; if (!NEXT_IS_NUMBER()) continue; @@ -625,10 +629,11 @@ static int netem_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) } if (gemodel) { - fprintf(f, "loss gemodel p %s", + fprintf(f, " loss gemodel p %s", sprint_percent(gemodel->p, b1)); fprintf(f, " r %s", sprint_percent(gemodel->r, b1)); - fprintf(f, " 1-h %s", sprint_percent(gemodel->h, b1)); + fprintf(f, " 1-h %s", sprint_percent(max_percent_value - + gemodel->h, b1)); fprintf(f, " 1-k %s", sprint_percent(gemodel->k1, b1)); }