matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

No need to initialize rtattr fields before parsing 

Since parse_rtattr_flags() calls memset already, there is no need for
callers to do so themselves.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
This commit is contained in:
Phil Sutter 2016-07-18 16:48:44 +02:00 committed by Stephen Hemminger
parent f89bb0210f
commit 30a8842c49
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ip/ipaddress.c
View File

@ -449,7 +449,7 @@ static void print_num(FILE *fp, unsigned int width, uint64_t count)
static void print_vf_stats64(FILE *fp, struct rtattr *vfstats) static void print_vf_stats64(FILE *fp, struct rtattr *vfstats)
{ {
struct rtattr *vf[IFLA_VF_STATS_MAX + 1] = {}; struct rtattr *vf[IFLA_VF_STATS_MAX + 1];
if (vfstats->rta_type != IFLA_VF_STATS) { if (vfstats->rta_type != IFLA_VF_STATS) {
fprintf(stderr, "BUG: rta type is %d\n", vfstats->rta_type); fprintf(stderr, "BUG: rta type is %d\n", vfstats->rta_type);

4
tc/tc_class.c
View File

@ -219,7 +219,7 @@ static void graph_cls_show(FILE *fp, char *buf, struct hlist_head *root_list,
{ {
struct hlist_node *n, *tmp_cls; struct hlist_node *n, *tmp_cls;
char cls_id_str[256] = {}; char cls_id_str[256] = {};
struct rtattr *tb[TCA_MAX + 1] = {}; struct rtattr *tb[TCA_MAX + 1];
struct qdisc_util *q; struct qdisc_util *q;
char str[100] = {}; char str[100] = {};
@ -304,7 +304,7 @@ int print_class(const struct sockaddr_nl *who,
FILE *fp = (FILE *)arg; FILE *fp = (FILE *)arg;
struct tcmsg *t = NLMSG_DATA(n); struct tcmsg *t = NLMSG_DATA(n);
int len = n->nlmsg_len; int len = n->nlmsg_len;
struct rtattr *tb[TCA_MAX + 1] = {}; struct rtattr *tb[TCA_MAX + 1];
struct qdisc_util *q; struct qdisc_util *q;
char abuf[256]; char abuf[256];