matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ipila: Fixed unitialized variables 

Initialize locator and locator_match to zero and only do
addattr if they have been set.

Signed-off-by: Tom Herbert <tom@herbertland.com>
This commit is contained in:
Tom Herbert 2016-08-15 16:30:22 -07:00 committed by Stephen Hemminger
parent 7e33b09331
commit 2d01b393f4
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ip/ipila.c
View File

@ -149,8 +149,8 @@ static int do_list(int argc, char **argv)
static int ila_parse_opt(int argc, char **argv, struct nlmsghdr *n, static int ila_parse_opt(int argc, char **argv, struct nlmsghdr *n,
bool adding) bool adding)
{ {
__u64 locator; __u64 locator = 0;
__u64 locator_match; __u64 locator_match = 0;
int ifindex = 0; int ifindex = 0;
bool loc_set = false; bool loc_set = false;
bool loc_match_set = false; bool loc_match_set = false;
@ -202,8 +202,11 @@ static int ila_parse_opt(int argc, char **argv, struct nlmsghdr *n,
} }
} }
addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match); if (loc_match_set)
addattr64(n, 1024, ILA_ATTR_LOCATOR, locator); addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);
if (loc_set)
addattr64(n, 1024, ILA_ATTR_LOCATOR, locator);
if (ifindex_set) if (ifindex_set)
addattr32(n, 1024, ILA_ATTR_IFINDEX, ifindex); addattr32(n, 1024, ILA_ATTR_IFINDEX, ifindex);