matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

iproute: Fix for missing 'Oifs:' display 

Covscan complained about dead code but after reading it, I assume the
author's intention was to prefix the interface list with 'Oifs: '.
Initializing first to 1 and setting it to 0 after above prefix was
printed should fix it.

Signed-off-by: Phil Sutter <phil@nwl.cc>
This commit is contained in:
Phil Sutter 2017-08-17 19:09:27 +02:00 committed by Stephen Hemminger
parent 2869262144
commit 2a86625619
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ip/iproute.c
View File

@ -624,7 +624,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
} }
if (tb[RTA_MULTIPATH]) { if (tb[RTA_MULTIPATH]) {
struct rtnexthop *nh = RTA_DATA(tb[RTA_MULTIPATH]); struct rtnexthop *nh = RTA_DATA(tb[RTA_MULTIPATH]);
int first = 0; int first = 1;
len = RTA_PAYLOAD(tb[RTA_MULTIPATH]); len = RTA_PAYLOAD(tb[RTA_MULTIPATH]);
@ -634,10 +634,12 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
if (nh->rtnh_len > len) if (nh->rtnh_len > len)
break; break;
if (r->rtm_flags&RTM_F_CLONED && r->rtm_type == RTN_MULTICAST) { if (r->rtm_flags&RTM_F_CLONED && r->rtm_type == RTN_MULTICAST) {
if (first) if (first) {
fprintf(fp, "Oifs: "); fprintf(fp, "Oifs: ");
else first = 0;
} else {
fprintf(fp, " "); fprintf(fp, " ");
}
} else } else
fprintf(fp, "%s\tnexthop ", _SL_); fprintf(fp, "%s\tnexthop ", _SL_);
if (nh->rtnh_len > sizeof(*nh)) { if (nh->rtnh_len > sizeof(*nh)) {