matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tunnels: use macros for IPv6 address comparison 

Replace open coded comparison of IPv6 addresses with appropriate macros.

Signed-off-by: Jiri Benc <jbenc@redhat.com>
This commit is contained in:
Jiri Benc 2016-09-05 11:35:27 +02:00 committed by Stephen Hemminger
parent c44003f7e7
commit 1f4c51c0e4
3 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ip/ip6tunnel.c
View File

@ -313,10 +313,10 @@ static int ip6_tnl_parm_match(const struct ip6_tnl_parm2 *p1,
{ {
return ((!p1->link || p1->link == p2->link) && return ((!p1->link || p1->link == p2->link) &&
(!p1->name[0] || strcmp(p1->name, p2->name) == 0) && (!p1->name[0] || strcmp(p1->name, p2->name) == 0) &&
(memcmp(&p1->laddr, &in6addr_any, sizeof(p1->laddr)) == 0 || (IN6_IS_ADDR_UNSPECIFIED(&p1->laddr) ||
memcmp(&p1->laddr, &p2->laddr, sizeof(p1->laddr)) == 0) && IN6_ARE_ADDR_EQUAL(&p1->laddr, &p2->laddr)) &&
(memcmp(&p1->raddr, &in6addr_any, sizeof(p1->raddr)) == 0 || (IN6_IS_ADDR_UNSPECIFIED(&p1->raddr) ||
memcmp(&p1->raddr, &p2->raddr, sizeof(p1->raddr)) == 0) && IN6_ARE_ADDR_EQUAL(&p1->raddr, &p2->raddr)) &&
(!p1->proto || !p2->proto || p1->proto == p2->proto) && (!p1->proto || !p2->proto || p1->proto == p2->proto) &&
(!p1->encap_limit || p1->encap_limit == p2->encap_limit) && (!p1->encap_limit || p1->encap_limit == p2->encap_limit) &&
(!p1->hop_limit || p1->hop_limit == p2->hop_limit) && (!p1->hop_limit || p1->hop_limit == p2->hop_limit) &&

6
ip/iplink_geneve.c
View File

@ -150,7 +150,7 @@ static int geneve_parse_opt(struct link_util *lu, int argc, char **argv,
return -1; return -1;
} }
if (!daddr && memcmp(&daddr6, &in6addr_any, sizeof(daddr6)) == 0) { if (!daddr && IN6_IS_ADDR_UNSPECIFIED(&daddr6)) {
fprintf(stderr, "geneve: remote link partner not specified\n"); fprintf(stderr, "geneve: remote link partner not specified\n");
return -1; return -1;
} }
@ -159,7 +159,7 @@ static int geneve_parse_opt(struct link_util *lu, int argc, char **argv,
addattr32(n, 1024, IFLA_GENEVE_ID, vni); addattr32(n, 1024, IFLA_GENEVE_ID, vni);
if (daddr) if (daddr)
addattr_l(n, 1024, IFLA_GENEVE_REMOTE, &daddr, 4); addattr_l(n, 1024, IFLA_GENEVE_REMOTE, &daddr, 4);
if (memcmp(&daddr6, &in6addr_any, sizeof(daddr6)) != 0) if (!IN6_IS_ADDR_UNSPECIFIED(&daddr6))
addattr_l(n, 1024, IFLA_GENEVE_REMOTE6, &daddr6, sizeof(struct in6_addr)); addattr_l(n, 1024, IFLA_GENEVE_REMOTE6, &daddr6, sizeof(struct in6_addr));
addattr32(n, 1024, IFLA_GENEVE_LABEL, label); addattr32(n, 1024, IFLA_GENEVE_LABEL, label);
addattr8(n, 1024, IFLA_GENEVE_TTL, ttl); addattr8(n, 1024, IFLA_GENEVE_TTL, ttl);
@ -203,7 +203,7 @@ static void geneve_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
struct in6_addr addr; struct in6_addr addr;
memcpy(&addr, RTA_DATA(tb[IFLA_GENEVE_REMOTE6]), sizeof(struct in6_addr)); memcpy(&addr, RTA_DATA(tb[IFLA_GENEVE_REMOTE6]), sizeof(struct in6_addr));
if (memcmp(&addr, &in6addr_any, sizeof(addr)) != 0) { if (!IN6_IS_ADDR_UNSPECIFIED(&addr)) {
if (!IN6_IS_ADDR_MULTICAST(&addr)) if (!IN6_IS_ADDR_MULTICAST(&addr))
fprintf(f, "remote %s ", fprintf(f, "remote %s ",
format_host(AF_INET6, sizeof(struct in6_addr), &addr)); format_host(AF_INET6, sizeof(struct in6_addr), &addr));

14
ip/iplink_vxlan.c
View File

@ -260,8 +260,8 @@ static int vxlan_parse_opt(struct link_util *lu, int argc, char **argv,
} }
if ((gaddr && daddr) || if ((gaddr && daddr) ||
(memcmp(&gaddr6, &in6addr_any, sizeof(gaddr6)) && (!IN6_IS_ADDR_UNSPECIFIED(&gaddr6) &&
memcmp(&daddr6, &in6addr_any, sizeof(daddr6)))) { !IN6_IS_ADDR_UNSPECIFIED(&daddr6))) {
fprintf(stderr, "vxlan: both group and remote cannot be specified\n"); fprintf(stderr, "vxlan: both group and remote cannot be specified\n");
return -1; return -1;
} }
@ -286,14 +286,14 @@ static int vxlan_parse_opt(struct link_util *lu, int argc, char **argv,
addattr_l(n, 1024, IFLA_VXLAN_GROUP, &gaddr, 4); addattr_l(n, 1024, IFLA_VXLAN_GROUP, &gaddr, 4);
else if (daddr) else if (daddr)
addattr_l(n, 1024, IFLA_VXLAN_GROUP, &daddr, 4); addattr_l(n, 1024, IFLA_VXLAN_GROUP, &daddr, 4);
if (memcmp(&gaddr6, &in6addr_any, sizeof(gaddr6)) != 0) if (!IN6_IS_ADDR_UNSPECIFIED(&gaddr6))
addattr_l(n, 1024, IFLA_VXLAN_GROUP6, &gaddr6, sizeof(struct in6_addr)); addattr_l(n, 1024, IFLA_VXLAN_GROUP6, &gaddr6, sizeof(struct in6_addr));
else if (memcmp(&daddr6, &in6addr_any, sizeof(daddr6)) != 0) else if (!IN6_IS_ADDR_UNSPECIFIED(&daddr6))
addattr_l(n, 1024, IFLA_VXLAN_GROUP6, &daddr6, sizeof(struct in6_addr)); addattr_l(n, 1024, IFLA_VXLAN_GROUP6, &daddr6, sizeof(struct in6_addr));
if (saddr) if (saddr)
addattr_l(n, 1024, IFLA_VXLAN_LOCAL, &saddr, 4); addattr_l(n, 1024, IFLA_VXLAN_LOCAL, &saddr, 4);
else if (memcmp(&saddr6, &in6addr_any, sizeof(saddr6)) != 0) else if (!IN6_IS_ADDR_UNSPECIFIED(&saddr6))
addattr_l(n, 1024, IFLA_VXLAN_LOCAL6, &saddr6, sizeof(struct in6_addr)); addattr_l(n, 1024, IFLA_VXLAN_LOCAL6, &saddr6, sizeof(struct in6_addr));
if (link) if (link)
@ -370,7 +370,7 @@ static void vxlan_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
struct in6_addr addr; struct in6_addr addr;
memcpy(&addr, RTA_DATA(tb[IFLA_VXLAN_GROUP6]), sizeof(struct in6_addr)); memcpy(&addr, RTA_DATA(tb[IFLA_VXLAN_GROUP6]), sizeof(struct in6_addr));
if (memcmp(&addr, &in6addr_any, sizeof(addr)) != 0) { if (!IN6_IS_ADDR_UNSPECIFIED(&addr)) {
if (IN6_IS_ADDR_MULTICAST(&addr)) if (IN6_IS_ADDR_MULTICAST(&addr))
fprintf(f, "group %s ", fprintf(f, "group %s ",
format_host(AF_INET6, sizeof(struct in6_addr), &addr)); format_host(AF_INET6, sizeof(struct in6_addr), &addr));
@ -390,7 +390,7 @@ static void vxlan_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
struct in6_addr addr; struct in6_addr addr;
memcpy(&addr, RTA_DATA(tb[IFLA_VXLAN_LOCAL6]), sizeof(struct in6_addr)); memcpy(&addr, RTA_DATA(tb[IFLA_VXLAN_LOCAL6]), sizeof(struct in6_addr));
if (memcmp(&addr, &in6addr_any, sizeof(addr)) != 0) if (!IN6_IS_ADDR_UNSPECIFIED(&addr))
fprintf(f, "local %s ", fprintf(f, "local %s ",
format_host(AF_INET6, sizeof(struct in6_addr), &addr)); format_host(AF_INET6, sizeof(struct in6_addr), &addr));
} }