matthias
/
iproute2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

iplink: validate maximum gso_max_size 

Validate the upper limit for gso_max_size, valid range is [0-65,536]
inclusive. Fix minor whitespace in iplink man page.

Signed-off-by: Solio Sarabia <solio.sarabia@intel.com>
This commit is contained in:
Solio Sarabia 2017-12-12 14:25:22 -08:00 committed by Stephen Hemminger
parent 3a2fbf007b
commit 051274b4db
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ip/iplink.c
View File

@ -853,7 +853,8 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req,
unsigned int max_size; unsigned int max_size;
NEXT_ARG(); NEXT_ARG();
if (get_unsigned(&max_size, *argv, 0) || max_size > UINT16_MAX) if (get_unsigned(&max_size, *argv, 0) ||
max_size > UINT16_MAX + 1)
invarg("Invalid \"gso_max_size\" value\n", invarg("Invalid \"gso_max_size\" value\n",
*argv); *argv);
addattr32(&req->n, sizeof(*req), IFLA_GSO_MAX_SIZE, max_size); addattr32(&req->n, sizeof(*req), IFLA_GSO_MAX_SIZE, max_size);

2
man/man8/ip-link.8.in
View File

@ -36,7 +36,7 @@ ip-link \- network device configuration
.RB "[ " numrxqueues .RB "[ " numrxqueues
.IR QUEUE_COUNT " ]" .IR QUEUE_COUNT " ]"
.br .br
.BR "[" gso_max_size .BR "[ " gso_max_size
.IR BYTES " ]" .IR BYTES " ]"
.RB "[ " gso_max_segs .RB "[ " gso_max_segs
.IR SEGMENTS " ]" .IR SEGMENTS " ]"