From 037660b3513aef53b98c2d0780d3781901986874 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 27 Oct 2015 15:46:20 +0900 Subject: [PATCH] qfq: fix parse_opt dead code Fix Coverity warning from dead code. --- tc/q_qfq.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tc/q_qfq.c b/tc/q_qfq.c index 05b4d84e..0e026749 100644 --- a/tc/q_qfq.c +++ b/tc/q_qfq.c @@ -38,16 +38,11 @@ static void explain_class(void) static int qfq_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct nlmsghdr *n) { - while (argc > 0) { - if (matches(*argv, "help") == 0) { - explain(); - return -1; - } else { + if (argc > 0) { + if (matches(*argv, "help") != 0) fprintf(stderr, "What is \"%s\"?\n", *argv); - explain(); - return -1; - } - argc--; argv++; + explain(); + return -1; } return 0;